Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and set ruby version, add style and spec ci #4

Merged
merged 19 commits into from
Sep 26, 2023
Merged

update and set ruby version, add style and spec ci #4

merged 19 commits into from
Sep 26, 2023

Conversation

mkhinda29
Copy link
Contributor

@mkhinda29 mkhinda29 commented Sep 25, 2023 •
edited
Loading

Updating some dependencies.
Adding rubocop style checks and rspec CI

Updating bundler: bundle update --bundler

@mkhinda29 mkhinda29 self-assigned this Sep 25, 2023
@github-actions
Copy link

Simplecov Report

Covered Threshold
100% 100%

@Parth-Rewind Parth-Rewind self-assigned this Sep 25, 2023
@Parth-Rewind Parth-Rewind added the dependencies Pull requests that update a dependency file label Sep 25, 2023
@Parth-Rewind Parth-Rewind marked this pull request as ready for review September 25, 2023 20:01
@mkhinda29
Copy link
Contributor Author

With your change to the gem name, I think we should rename the repo too. What do you think?
image

@Parth-Rewind
Copy link
Contributor

With your change to the gem name, I think we should rename the repo too. What do you think? image

The gem name is still
gem.name = 'omniauth-azure-devops'

@Parth-Rewind Parth-Rewind merged commit ae9455f into main Sep 26, 2023
5 checks passed
@Parth-Rewind Parth-Rewind deleted the feature/update-deps-add-ci branch September 26, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlafram danlafram danlafram approved these changes

@Parth-Rewind Parth-Rewind Awaiting requested review from Parth-Rewind Parth-Rewind is a code owner

@ntran-rw ntran-rw Awaiting requested review from ntran-rw ntran-rw is a code owner

@calvinc03-rewind calvinc03-rewind Awaiting requested review from calvinc03-rewind calvinc03-rewind is a code owner

Assignees

@mkhinda29 mkhinda29

@Parth-Rewind Parth-Rewind

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkhinda29 @Parth-Rewind @danlafram